[Refactor] check existence of node_modules
#190
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This offers a small but useful performance improvement by avoiding unnecessary stat calls.
ljharb
approved these changes
May 10, 2019
|
Please do note tho; this code is in master for v2, which is unreleased; it'd be great to get a PR into the |
keithamus
added a commit
to keithamus/resolve
that referenced
this pull request
May 14, 2019
This brings the same perf improvements as in 4cf8928 (browserify#190)
keithamus
added a commit
to keithamus/resolve
that referenced
this pull request
May 14, 2019
This is a backport of 4cf8928 and fa11d48 (browserify#190 and browserify#191) to the 1.x branch. This adds the `isDirectory` option which is needed to drive the directory lookups. This offers a small but useful performance improvement by avoiding unnecessary stat calls.
ljharb
pushed a commit
to keithamus/resolve
that referenced
this pull request
May 14, 2019
This brings the same perf improvements as in 4cf8928 / browserify#190
ljharb
pushed a commit
to keithamus/resolve
that referenced
this pull request
May 15, 2019
This is a backport of 4cf8928 and fa11d48 (browserify#190 and browserify#191) to the 1.x branch. This offers a small but useful performance improvement by avoiding unnecessary stat calls.
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers a small but useful performance improvement by avoiding unnecessary stat calls.
Fixes #116